New: Add span wrapper around view button text (fixes #211) #216
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirsty-hames
approved these changes
May 7, 2025
There was a problem hiding this comment.
Thanks @swashbuck. I've previously used font-size: 0 to visually hide linkText whilst keeping it accessible for SRs however wrapping the text using a <span> is much cleaner and consistent with other Adapt buttons containing text and/or icons.
This works as expected thanks and I'm also in favour of #217 :)
oliverfoster
approved these changes
May 13, 2025
github-project-automation
bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
|
🎉 This PR is included in version 7.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #211
New
spanwrapper around the view button text. This will make it easier to hide the text if we want an icon-only button.Notes
In #217 , I have suggested the option to add an icon to the button via config.